Refactor presets scaling and clean up patterns

Made-with: Cursor

pico/src/patterns/point.py

@@ -3,66 +3,16 @@ class Point:
         self.driver = driver
 
     def run(self, preset):
-        """
-        Point pattern: color bands defined by n ranges.
-
-        - n1–n2: LEDs with color1 (c[0])
-        - n3–n4: LEDs with color2 (c[1])
-        - n5–n6: LEDs with color3 (c[2])
-        - n7–n8: LEDs with color4 (c[3])
-
-        All indices are along the logical ring (driver.n), inclusive ranges.
-        """
-        num_leds = self.driver.num_leds
-
-        # Base colors (up to 4), missing ones default to black
-        colors = list(preset.c) if getattr(preset, "c", None) else []
-        while len(colors) < 4:
-            colors.append((0, 0, 0))
-
-        # Apply preset/global brightness once per color
-        c1 = self.driver.apply_brightness(colors[0], preset.b)
-        c2 = self.driver.apply_brightness(colors[1], preset.b)
-        c3 = self.driver.apply_brightness(colors[2], preset.b)
-        c4 = self.driver.apply_brightness(colors[3], preset.b)
+            # Apply preset/global brightness once per color
+        c1 = self.driver.apply_brightness(preset.c[0], preset.b)
+        c2 = self.driver.apply_brightness(preset.c[1], preset.b)
+        c3 = self.driver.apply_brightness(preset.c[2], preset.b)
+        c4 = self.driver.apply_brightness(preset.c[3], preset.b)
 
         # Helper to normalize and clamp a range
-        def norm_range(a, b):
-            a = int(a)
-            b = int(b)
-            if a > b:
-                a, b = b, a
-            if b < 0 or a >= num_leds:
-                return None
-            a = max(0, a)
-            b = min(num_leds - 1, b)
-            if a > b:
-                return None
-            return a, b
-
-        ranges = []
-        r1 = norm_range(getattr(preset, "n1", 0), getattr(preset, "n2", -1))
-        if r1:
-            ranges.append((r1[0], r1[1], c1))
-        r2 = norm_range(getattr(preset, "n3", 0), getattr(preset, "n4", -1))
-        if r2:
-            ranges.append((r2[0], r2[1], c2))
-        r3 = norm_range(getattr(preset, "n5", 0), getattr(preset, "n6", -1))
-        if r3:
-            ranges.append((r3[0], r3[1], c3))
-        r4 = norm_range(getattr(preset, "n7", 0), getattr(preset, "n8", -1))
-        if r4:
-            ranges.append((r4[0], r4[1], c4))
-
-        # Static draw: last range wins on overlaps
-        for i in range(num_leds):
-            color = (0, 0, 0)
-            for start, end, c in ranges:
-                if start <= i <= end:
-                    color = c
-            self.driver.n[i] = color
-        self.driver.n.write()
-
-        while True:
-            yield
-
+        self.driver.fill_n(c1, preset.n1, preset.n2)
+        self.driver.fill_n(c2, preset.n3, preset.n4)
+        self.driver.fill_n(c3, preset.n5, preset.n6)
+        self.driver.fill_n(c4, preset.n7, preset.n8)
+        self.driver.show_all()
+