technicalkiwi/led-driver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(patterns): use preset background fallback across animations

Browse Source 
Align pattern background rendering to use preset.background_or(...) and update pulse/radiate single-step behaviour to preserve visible frames and step progression.
This commit is contained in:
Jimmy
2026-05-09 14:28:05 +12:00
parent fbebe9f4f9
commit 4879fcfe90
20 changed files with 32 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/main.py
View File

@@ -173,13 +173,6 @@ async def presets_loop():
while True:
presets.tick()
wdt.feed()
if bool(getattr(presets, "debug", False)):
now = utime.ticks_ms()
if utime.ticks_diff(now, last_mem_log) >= 5000:
gc.collect()
print("mem runtime:", {"free": gc.mem_free(), "alloc": gc.mem_alloc()})
last_mem_log = now
# tick() does not await; yield so UDP hello and HTTP/WebSocket can run.
await asyncio.sleep(0)

2
src/patterns/bar_graph.py
View File

@@ -16,7 +16,7 @@ class BarGraph:
target = (self.driver.num_leds * level) // 100
lit = self.driver.apply_brightness(colors[0], preset.b)
unlit = self.driver.apply_brightness(
colors[-1],
preset.background_or(colors),
preset.b,
)
for i in range(self.driver.num_leds):

5
src/patterns/blink.py
View File

@@ -9,6 +9,7 @@ class Blink:
"""Blink pattern: toggles LEDs on/off using preset delay, cycling through colors."""
# Use provided colors, or default to white if none
colors = preset.c if preset.c else [(255, 255, 255)]
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
color_index = 0
state = True # True = on, False = off
last_update = utime.ticks_ms()
@@ -25,8 +26,8 @@ class Blink:
# Advance to next color for the next "on" phase
color_index += 1
else:
# "Off" phase should actually be off.
self.driver.fill((0, 0, 0))
# Inactive phase uses the preset background color.
self.driver.fill(bg_color)
state = not state
last_update = utime.ticks_add(last_update, delay_ms)
# Yield once per tick so other logic can run

2
src/patterns/chase.py
View File

@@ -26,7 +26,7 @@ class Chase:
color0 = self.driver.apply_brightness(color0, preset.b)
color1 = self.driver.apply_brightness(color1, preset.b)
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
n1 = max(1, int(preset.n1)) # LEDs of color 0
n2 = max(1, int(preset.n2)) # LEDs of color 1

4
src/patterns/circle.py
View File

@@ -31,10 +31,10 @@ class Circle:
base0 = base1 = (255, 255, 255)
elif len(colors) == 1:
base0 = colors[0]
base1 = colors[-1]
base1 = preset.background_or(colors)
else:
base0 = colors[0]
base1 = colors[-1]
base1 = preset.background_or(colors)
color0 = self.driver.apply_brightness(base0, preset.b)
color1 = self.driver.apply_brightness(base1, preset.b)

2
src/patterns/clock_sweep.py
View File

@@ -15,7 +15,7 @@ class ClockSweep:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg = self.driver.apply_brightness(colors[-1], preset.b)
bg = self.driver.apply_brightness(preset.background_or(colors), preset.b)
fg = self.driver.apply_brightness(colors[0], preset.b)
for i in range(self.driver.num_leds):
self.driver.n[i] = bg

2
src/patterns/comet_dual.py
View File

@@ -17,7 +17,7 @@ class CometDual:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
self.driver.n[i] = bg_color
c1 = self.driver.apply_brightness(colors[0 % len(colors)], preset.b)

2
src/patterns/fireflies.py
View File

@@ -16,7 +16,7 @@ class Fireflies:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
self.driver.n[i] = bg_color
for b in bugs:

2
src/patterns/heartbeat.py
View File

@@ -17,7 +17,7 @@ class Heartbeat:
beat_gap = max(20, int(preset.d))
colors = preset.c if preset.c else [(255, 0, 40)]
lit_color = self.driver.apply_brightness(colors[0], preset.b)
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
phase_durations = (p1, beat_gap, p2, pause)
phase_colors = (lit_color, bg_color, lit_color, bg_color)

2
src/patterns/marquee.py
View File

@@ -17,7 +17,7 @@ class Marquee:
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
c = self.driver.apply_brightness(colors[0], preset.b)
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
m = (i + phase) % (on_len + off_len)
self.driver.n[i] = c if m < on_len else bg_color

2
src/patterns/orbit.py
View File

@@ -15,7 +15,7 @@ class Orbit:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
self.driver.n[i] = bg_color
for k in range(orbits):

11
src/patterns/pulse.py
View File

@@ -6,19 +6,19 @@ class Pulse:
self.driver = driver
def run(self, preset):
self.driver.off()
# Get colors from preset
colors = preset.c
if not colors:
colors = [(255, 255, 255)]
bg_base = preset.background_or(colors)
self.driver.fill(self.driver.apply_brightness(bg_base, preset.b))
color_index = 0
color_index = self.driver.step % max(1, len(colors))
cycle_start = utime.ticks_ms()
# State machine based pulse using a single generator loop
while True:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(bg_base, preset.b)
# Read current timing parameters from preset
attack_ms = max(0, int(preset.n1)) # Attack time in ms
hold_ms = max(0, int(preset.n2)) # Hold time in ms
@@ -53,7 +53,8 @@ class Pulse:
self.driver.fill(bg_color)
else:
# End of cycle, move to next color and restart timing
color_index += 1
color_index = (color_index + 1) % max(1, len(colors))
self.driver.step = color_index
cycle_start = now
if not preset.a:
break

7
src/patterns/radiate.py
View File

@@ -17,7 +17,7 @@ class Radiate:
"""
colors = preset.c if preset.c else [(255, 255, 255)]
base_on = colors[0]
base_off = colors[-1]
base_off = preset.background_or(colors)
spacing = max(1, int(preset.n1))
outward_ms = max(1, int(preset.n2))
@@ -34,8 +34,9 @@ class Radiate:
dbg_banner = False
if not preset.a:
# Single-step render uses only the first instant pulse.
active_pulses = [utime.ticks_ms()]
# Single-shot mode exits after one rendered frame. Seed the pulse
# slightly in the past so this frame is visible before returning.
active_pulses = [utime.ticks_add(utime.ticks_ms(), -1)]
while True:
now = utime.ticks_ms()

2
src/patterns/rain_drops.py
View File

@@ -16,7 +16,7 @@ class RainDrops:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
self.driver.n[i] = bg_color
if random.randint(0, 255) < rate:

2
src/patterns/scanner.py
View File

@@ -27,7 +27,7 @@ class Scanner:
if utime.ticks_diff(now, last_update) >= delay_ms:
base = colors[color_index % len(colors)]
base = self.driver.apply_brightness(base, preset.b)
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
dist = i - center
if dist < 0:

2
src/patterns/segment_chase.py
View File

@@ -24,7 +24,7 @@ class SegmentChase:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
for i in range(self.driver.num_leds):
seg_idx = i // seg
in_seg = i % seg

2
src/patterns/snowfall.py
View File

@@ -16,7 +16,7 @@ class Snowfall:
d = max(1, int(preset.d))
now = utime.ticks_ms()
if utime.ticks_diff(now, last) >= d:
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
if random.randint(0, 255) < density:
flakes.append([self.driver.num_leds - 1, random.randint(0, len(colors)-1)])
for i in range(self.driver.num_leds):

2
src/patterns/strobe_burst.py
View File

@@ -16,7 +16,7 @@ class StrobeBurst:
cooldown = max(1, int(preset.n3) if int(preset.n3) > 0 else 400)
on_ms = max(1, int(preset.d) // 2)
c = self.driver.apply_brightness(colors[0], preset.b)
bg_color = self.driver.apply_brightness(colors[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(colors), preset.b)
now = utime.ticks_ms()
if state == "flash_on":

2
src/patterns/twinkle.py
View File

@@ -39,7 +39,7 @@ class Twinkle:
"""Twinkle: n1 activity, n2 density; n3/n4 min/max length of adjacent on/off runs."""
palette = self._palette(preset)
num = self.driver.num_leds
bg_color = self.driver.apply_brightness(palette[-1], preset.b)
bg_color = self.driver.apply_brightness(preset.background_or(palette), preset.b)
if num <= 0:
while True:
yield

3
src/preset.py
View File

@@ -100,6 +100,9 @@ class Preset:
def auto(self, value):
self.a = value
def background_or(self, colors=None, default=(0, 0, 0)):
return default
def to_dict(self):
return {
"p": self.p,