technicalkiwi/led-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(zones): rename tabs to zones across api, ui, and storage

Browse Source 
Made-with: Cursor
This commit is contained in:
pi
2026-04-06 18:22:03 +12:00
parent d1ffb857c8
commit fd618d7714
35 changed files with 1347 additions and 1303 deletions
Download Patch File Download Diff File Expand all files Collapse all files

168
tests/test_endpoints.py
View File

@@ -91,115 +91,115 @@ def test_tabs(client: TestClient) -> bool:
# Test 1: List tabs
total += 1
try:
response = client.get('/tabs')
response = client.get('/zones')
if response.status_code == 200:
data = response.json()
print(f"✓ GET /tabs - Found {len(data.get('tabs', {}))} tabs")
print(f"✓ GET /zones - Found {len(data.get('zones', {}))} tabs")
passed += 1
else:
print(f"✗ GET /tabs - Status: {response.status_code}")
print(f"✗ GET /zones - Status: {response.status_code}")
except Exception as e:
print(f"✗ GET /tabs - Error: {e}")
print(f"✗ GET /zones - Error: {e}")
# Test 2: Create tab
# Test 2: Create zone
total += 1
try:
tab_data = {
"name": "Test Tab",
"name": "Test Zone",
"names": ["1", "2"]
}
response = client.post('/tabs', json_data=tab_data)
response = client.post('/zones', json_data=tab_data)
if response.status_code == 201:
created_tab = response.json()
# Response format: {tab_id: {tab_data}}
# Response format: {zone_id: {tab_data}}
if isinstance(created_tab, dict):
# Get the first key which should be the tab ID
tab_id = next(iter(created_tab.keys())) if created_tab else None
# Get the first key which should be the zone ID
zone_id = next(iter(created_tab.keys())) if created_tab else None
else:
tab_id = None
print(f"✓ POST /tabs - Created tab: {tab_id}")
zone_id = None
print(f"✓ POST /zones - Created zone: {zone_id}")
passed += 1
# Test 3: Get specific tab
if tab_id:
# Test 3: Get specific zone
if zone_id:
total += 1
response = client.get(f'/tabs/{tab_id}')
response = client.get(f'/zones/{zone_id}')
if response.status_code == 200:
print(f"✓ GET /tabs/{tab_id} - Retrieved tab")
print(f"✓ GET /zones/{zone_id} - Retrieved zone")
passed += 1
else:
print(f"✗ GET /tabs/{tab_id} - Status: {response.status_code}")
print(f"✗ GET /zones/{zone_id} - Status: {response.status_code}")
# Test 4: Set current tab
# Test 4: Set current zone
total += 1
response = client.post(f'/tabs/{tab_id}/set-current')
response = client.post(f'/zones/{zone_id}/set-current')
if response.status_code == 200:
print(f"✓ POST /tabs/{tab_id}/set-current - Set current tab")
print(f"✓ POST /zones/{zone_id}/set-current - Set current zone")
# Check cookie was set
cookie = client.get_cookie('current_tab')
if cookie == tab_id:
print(f" ✓ Cookie 'current_tab' set to {tab_id}")
cookie = client.get_cookie('current_zone')
if cookie == zone_id:
print(f" ✓ Cookie 'current_zone' set to {zone_id}")
passed += 1
else:
print(f"✗ POST /tabs/{tab_id}/set-current - Status: {response.status_code}")
print(f"✗ POST /zones/{zone_id}/set-current - Status: {response.status_code}")
# Test 5: Get current tab
# Test 5: Get current zone
total += 1
response = client.get('/tabs/current')
response = client.get('/zones/current')
if response.status_code == 200:
data = response.json()
if data.get('tab_id') == tab_id:
print(f"✓ GET /tabs/current - Current tab is {tab_id}")
if data.get('zone_id') == zone_id:
print(f"✓ GET /zones/current - Current zone is {zone_id}")
passed += 1
else:
print(f"✗ GET /tabs/current - Wrong tab ID")
print(f"✗ GET /zones/current - Wrong zone ID")
else:
print(f"✗ GET /tabs/current - Status: {response.status_code}")
print(f"✗ GET /zones/current - Status: {response.status_code}")
# Test 6: Update tab (edit functionality)
# Test 6: Update zone (edit functionality)
total += 1
update_data = {
"name": "Updated Test Tab",
"name": "Updated Test Zone",
"names": ["1", "2", "3"] # Update device IDs too
}
response = client.put(f'/tabs/{tab_id}', json_data=update_data)
response = client.put(f'/zones/{zone_id}', json_data=update_data)
if response.status_code == 200:
updated = response.json()
if updated.get('name') == "Updated Test Tab" and updated.get('names') == ["1", "2", "3"]:
print(f"✓ PUT /tabs/{tab_id} - Updated tab (name and device IDs)")
if updated.get('name') == "Updated Test Zone" and updated.get('names') == ["1", "2", "3"]:
print(f"✓ PUT /zones/{zone_id} - Updated zone (name and device IDs)")
passed += 1
else:
print(f"✗ PUT /tabs/{tab_id} - Update didn't work correctly")
print(f" Expected name='Updated Test Tab', got '{updated.get('name')}'")
print(f"✗ PUT /zones/{zone_id} - Update didn't work correctly")
print(f" Expected name='Updated Test Zone', got '{updated.get('name')}'")
print(f" Expected names=['1','2','3'], got {updated.get('names')}")
else:
print(f"✗ PUT /tabs/{tab_id} - Status: {response.status_code}, Response: {response.text}")
print(f"✗ PUT /zones/{zone_id} - Status: {response.status_code}, Response: {response.text}")
# Test 6b: Verify update persisted
total += 1
response = client.get(f'/tabs/{tab_id}')
response = client.get(f'/zones/{zone_id}')
if response.status_code == 200:
verified = response.json()
if verified.get('name') == "Updated Test Tab":
print(f"✓ GET /tabs/{tab_id} - Verified update persisted")
if verified.get('name') == "Updated Test Zone":
print(f"✓ GET /zones/{zone_id} - Verified update persisted")
passed += 1
else:
print(f"✗ GET /tabs/{tab_id} - Update didn't persist")
print(f"✗ GET /zones/{zone_id} - Update didn't persist")
else:
print(f"✗ GET /tabs/{tab_id} - Status: {response.status_code}")
print(f"✗ GET /zones/{zone_id} - Status: {response.status_code}")
# Test 7: Delete tab
# Test 7: Delete zone
total += 1
response = client.delete(f'/tabs/{tab_id}')
response = client.delete(f'/zones/{zone_id}')
if response.status_code == 200:
print(f"✓ DELETE /tabs/{tab_id} - Deleted tab")
print(f"✓ DELETE /zones/{zone_id} - Deleted zone")
passed += 1
else:
print(f"✗ DELETE /tabs/{tab_id} - Status: {response.status_code}")
print(f"✗ DELETE /zones/{zone_id} - Status: {response.status_code}")
else:
print(f"✗ POST /tabs - Status: {response.status_code}, Response: {response.text}")
print(f"✗ POST /zones - Status: {response.status_code}, Response: {response.text}")
except Exception as e:
print(f"✗ POST /tabs - Error: {e}")
print(f"✗ POST /zones - Error: {e}")
import traceback
traceback.print_exc()
@@ -409,87 +409,87 @@ def test_patterns(client: TestClient) -> bool:
return passed == total
def test_tab_edit_workflow(client: TestClient) -> bool:
"""Test complete tab edit workflow like a browser would."""
print("\n=== Testing Tab Edit Workflow ===")
"""Test complete zone edit workflow like a browser would."""
print("\n=== Testing Zone Edit Workflow ===")
passed = 0
total = 0
# Step 1: Create a tab to edit
# Step 1: Create a zone to edit
total += 1
try:
tab_data = {
"name": "Tab to Edit",
"name": "Zone to Edit",
"names": ["1"]
}
response = client.post('/tabs', json_data=tab_data)
response = client.post('/zones', json_data=tab_data)
if response.status_code == 201:
created = response.json()
if isinstance(created, dict):
tab_id = next(iter(created.keys())) if created else None
zone_id = next(iter(created.keys())) if created else None
else:
tab_id = None
zone_id = None
if tab_id:
print(f"✓ Created tab {tab_id} for editing")
if zone_id:
print(f"✓ Created zone {zone_id} for editing")
passed += 1
# Step 2: Get the tab to verify initial state
# Step 2: Get the zone to verify initial state
total += 1
response = client.get(f'/tabs/{tab_id}')
response = client.get(f'/zones/{zone_id}')
if response.status_code == 200:
original_tab = response.json()
print(f"✓ Retrieved tab - Name: '{original_tab.get('name')}', IDs: {original_tab.get('names')}")
print(f"✓ Retrieved zone - Name: '{original_tab.get('name')}', IDs: {original_tab.get('names')}")
passed += 1
# Step 3: Edit the tab (simulate browser edit form submission)
# Step 3: Edit the zone (simulate browser edit form submission)
total += 1
edit_data = {
"name": "Edited Tab Name",
"name": "Edited Zone Name",
"names": ["2", "3", "4"]
}
response = client.put(f'/tabs/{tab_id}', json_data=edit_data)
response = client.put(f'/zones/{zone_id}', json_data=edit_data)
if response.status_code == 200:
edited = response.json()
if edited.get('name') == "Edited Tab Name" and edited.get('names') == ["2", "3", "4"]:
print(f"✓ PUT /tabs/{tab_id} - Successfully edited tab")
if edited.get('name') == "Edited Zone Name" and edited.get('names') == ["2", "3", "4"]:
print(f"✓ PUT /zones/{zone_id} - Successfully edited zone")
print(f" New name: '{edited.get('name')}'")
print(f" New device IDs: {edited.get('names')}")
passed += 1
else:
print(f"✗ PUT /tabs/{tab_id} - Edit didn't work correctly")
print(f"✗ PUT /zones/{zone_id} - Edit didn't work correctly")
print(f" Got: {edited}")
else:
print(f"✗ PUT /tabs/{tab_id} - Status: {response.status_code}, Response: {response.text}")
print(f"✗ PUT /zones/{zone_id} - Status: {response.status_code}, Response: {response.text}")
# Step 4: Verify edit persisted by getting the tab again
# Step 4: Verify edit persisted by getting the zone again
total += 1
response = client.get(f'/tabs/{tab_id}')
response = client.get(f'/zones/{zone_id}')
if response.status_code == 200:
verified = response.json()
if verified.get('name') == "Edited Tab Name" and verified.get('names') == ["2", "3", "4"]:
print(f"✓ GET /tabs/{tab_id} - Verified edit persisted")
if verified.get('name') == "Edited Zone Name" and verified.get('names') == ["2", "3", "4"]:
print(f"✓ GET /zones/{zone_id} - Verified edit persisted")
passed += 1
else:
print(f"✗ GET /tabs/{tab_id} - Edit didn't persist")
print(f" Expected name='Edited Tab Name', got '{verified.get('name')}'")
print(f"✗ GET /zones/{zone_id} - Edit didn't persist")
print(f" Expected name='Edited Zone Name', got '{verified.get('name')}'")
print(f" Expected names=['2','3','4'], got {verified.get('names')}")
else:
print(f"✗ GET /tabs/{tab_id} - Status: {response.status_code}")
print(f"✗ GET /zones/{zone_id} - Status: {response.status_code}")
# Step 5: Clean up - delete the test tab
# Step 5: Clean up - delete the test zone
total += 1
response = client.delete(f'/tabs/{tab_id}')
response = client.delete(f'/zones/{zone_id}')
if response.status_code == 200:
print(f"✓ DELETE /tabs/{tab_id} - Cleaned up test tab")
print(f"✓ DELETE /zones/{zone_id} - Cleaned up test zone")
passed += 1
else:
print(f"✗ DELETE /tabs/{tab_id} - Status: {response.status_code}")
print(f"✗ DELETE /zones/{zone_id} - Status: {response.status_code}")
else:
print(f"✗ Failed to extract tab ID from create response")
print(f"✗ Failed to extract zone ID from create response")
else:
print(f"✗ POST /tabs - Status: {response.status_code}, Response: {response.text}")
print(f"✗ POST /zones - Status: {response.status_code}, Response: {response.text}")
except Exception as e:
print(f"✗ Tab edit workflow - Error: {e}")
print(f"✗ Zone edit workflow - Error: {e}")
import traceback
traceback.print_exc()
@@ -505,7 +505,7 @@ def test_static_files(client: TestClient) -> bool:
static_files = [
'/static/style.css',
'/static/app.js',
'/static/tabs.js',
'/static/zones.js',
'/static/presets.js',
'/static/profiles.js',
'/static/devices.js',
@@ -544,7 +544,7 @@ def main():
# Run all tests
results.append(("Tabs", test_tabs(client)))
results.append(("Tab Edit Workflow", test_tab_edit_workflow(client)))
results.append(("Zone Edit Workflow", test_tab_edit_workflow(client)))
results.append(("Profiles", test_profiles(client)))
results.append(("Presets", test_presets(client)))
results.append(("Patterns", test_patterns(client)))