From d89ed781ef0cceaeb6921cf316c60fa841dc61eb Mon Sep 17 00:00:00 2001 From: Einar Forselv Date: Sun, 8 Dec 2019 00:08:41 +0100 Subject: [PATCH] Comment on log streaming for docker ce 17 and 18 --- src/restic_compose_backup/backup_runner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/restic_compose_backup/backup_runner.py b/src/restic_compose_backup/backup_runner.py index 08ad86e..8474f9f 100644 --- a/src/restic_compose_backup/backup_runner.py +++ b/src/restic_compose_backup/backup_runner.py @@ -35,8 +35,8 @@ def run(image: str = None, command: str = None, volumes: dict = None, line = "" while True: try: - # TODO: figure out why.. - # Apparently the stream can be bytes or strings. + # Make log streaming work for docker ce 17 and 18. + # For some reason strings are returned instead if bytes. data = next(stream) if isinstance(data, bytes): line += data.decode()