From a2ab9c6039b8985af88821335b0ba75c180d0d9b Mon Sep 17 00:00:00 2001
From: hweisbach <hweisbach@81a1dc3b-b13d-400b-aceb-764788c761c2>
Date: Fri, 3 May 2013 13:01:20 +0000
Subject: [PATCH] avrftdi_tpi.c: Remove set_pin() to set MOSI high
This is not necessary any more, because the "frame" ends in logic 1, so
the pin is high anyway and the MPSSE keeps the pin value as long as it
is idle. Setting the pin low would cause the TPI physical layer in the
AVR part to detect a collision.
git-svn-id: svn://svn.savannah.nongnu.org/avrdude/trunk/avrdude@1159 81a1dc3b-b13d-400b-aceb-764788c761c2
---
ChangeLog | 1 +
avrftdi_tpi.c | 4 ----
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 52d6090c..8ba2a130 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,7 @@
avrftdi_log.
* avrftdi_tpi.c: Do all I/O in terms of pgm->cmd_tpi()-calls instead of
avrftdi_tpi_[read,write]_byte().
+ Remove unnecessary set_pin call to set MOSI high, speeds up I/O.
2013-05-02 Hannes Weisbach <hannes_weisbach@gmx.net>
diff --git a/avrftdi_tpi.c b/avrftdi_tpi.c
index 578ff6e4..6f14196c 100644
--- a/avrftdi_tpi.c
+++ b/avrftdi_tpi.c
@@ -181,9 +181,6 @@ avrftdi_tpi_read_byte(PROGRAMMER * pgm, unsigned char * byte)
unsigned char buffer[4];
- /* set it high, so the TPI won't detect we're driving the line */
- to_pdata(pgm)->set_pin(pgm, PIN_AVR_MOSI, ON);
-
buffer[0] = MPSSE_DO_READ | MPSSE_LSB;
buffer[1] = (bytes-1) & 0xff;
buffer[2] = ((bytes-1) >> 8) & 0xff;
@@ -223,7 +220,6 @@ avrftdi_tpi_program_enable(PROGRAMMER * pgm, AVRPART * p)
{
int retry;
int err;
- int i;
unsigned char cmd[2];
unsigned char response;