From 319ee2db9c0ce70d266c48b82969036fbbe3632b Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 17:34:18 +0000 Subject: [PATCH 01/22] Silence fall through warning in update.c --- src/update.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/update.c b/src/update.c index 0afcd9ea..ce4c2075 100644 --- a/src/update.c +++ b/src/update.c @@ -560,8 +560,9 @@ int do_op(const PROGRAMMER *pgm, const AVRPART *p, UPDATE *upd, enum updateflags pmsg_info("%d byte%s of %s%s written\n", fs.nbytes, update_plural(fs.nbytes), mem->desc, alias_mem_desc); - if (!(flags & UF_VERIFY)) // Fall through for auto verify unless -V was specified + if (!(flags & UF_VERIFY)) // Fall through for auto verify unless break; + // Fall through case DEVICE_VERIFY: // Verify that the in memory file is the same as what is on the chip From 79dd434d2055ae12a4ccc9c3928140ac806c7042 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 17:42:05 +0000 Subject: [PATCH 02/22] Silence sign-compare warnings in usbtiny.c --- src/usbtiny.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/usbtiny.c b/src/usbtiny.c index a69de8f3..5090f538 100644 --- a/src/usbtiny.c +++ b/src/usbtiny.c @@ -735,7 +735,7 @@ static int usbtiny_paged_write(const PROGRAMMER *pgm, const AVRPART *p, const AV } // we can only write a page at a time anyways - if (m->paged && chunk > page_size) + if (m->paged && chunk > (int) page_size) chunk = page_size; if (usb_out(pgm, @@ -752,8 +752,7 @@ static int usbtiny_paged_write(const PROGRAMMER *pgm, const AVRPART *p, const AV } next = addr + chunk; // Calculate what address we're at now - if (m->paged - && ((next % page_size) == 0 || next == maxaddr) ) { + if (m->paged && (next % page_size == 0 || next == (int) maxaddr) ) { // If we're at a page boundary, send the SPI command to flush it. avr_write_page(pgm, p, m, (unsigned long) addr); } From 246d2d502d5b00918f31ced7fa64de873bdc280a Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 18:25:00 +0000 Subject: [PATCH 03/22] Silence sign-compare warning in usb_hidapi.c --- src/usb_hidapi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/usb_hidapi.c b/src/usb_hidapi.c index 4a08c1f5..7dd78314 100644 --- a/src/usb_hidapi.c +++ b/src/usb_hidapi.c @@ -272,7 +272,9 @@ static int usbhid_recv(const union filedescriptor *fd, unsigned char *buf, size_ return -1; rv = i = hid_read_timeout(udev, buf, nbytes, 10000); - if (i != nbytes) + if (i < 0) + pmsg_error("hid_read_timeout(usb, %lu, 10000) failed\n", (unsigned long) nbytes); + else if ((size_t) i != nbytes) pmsg_error("short read, read only %d out of %lu bytes\n", i, (unsigned long) nbytes); if (verbose > 4) { @@ -291,6 +293,7 @@ static int usbhid_recv(const union filedescriptor *fd, unsigned char *buf, size_ } msg_trace2("\n"); } + return rv; } From 3611c89ee0e9849cb0cec2c6527ef8956b20dec1 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 18:32:51 +0000 Subject: [PATCH 04/22] Silence sign-compare warnings in usbasp.c --- src/usbasp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/usbasp.c b/src/usbasp.c index 35d3a2e1..9ae0dbc4 100644 --- a/src/usbasp.c +++ b/src/usbasp.c @@ -932,7 +932,7 @@ static int usbasp_spi_set_sck_period(const PROGRAMMER *pgm, double sckperiod) { pmsg_notice2("try to set SCK period to %g s (= %i Hz)\n", sckperiod, sckfreq); /* Check if programmer is capable of 3 MHz SCK, if not then ommit 3 MHz setting */ - int i; + size_t i; if (PDATA(pgm)->sck_3mhz) { pmsg_notice2("connected USBasp is capable of 3 MHz SCK\n"); i = 0; @@ -1122,7 +1122,7 @@ static int usbasp_tpi_paged_load(const PROGRAMMER *pgm, const AVRPART *p, const pr = addr + m->offset; readed = 0; - while(readed < n_bytes) + while(readed < (int) n_bytes) { clen = n_bytes - readed; if(clen > 32) @@ -1187,7 +1187,7 @@ static int usbasp_tpi_paged_write(const PROGRAMMER *pgm, const AVRPART *p, const usbasp_tpi_send_byte(pgm, TPI_OP_SSTPR(1)); usbasp_tpi_send_byte(pgm, (pr >> 8) ); - while(writed < n_bytes) + while(writed < (int) n_bytes) { clen = n_bytes - writed; if(clen > 32) From c6b2f12c047a5b8802b5b6e49e593e49353aaa3b Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 18:48:14 +0000 Subject: [PATCH 05/22] Silence sign-compare warnings in serialupdi.c --- src/serialupdi.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/serialupdi.c b/src/serialupdi.c index 5d221f88..972ab5ea 100644 --- a/src/serialupdi.c +++ b/src/serialupdi.c @@ -705,11 +705,17 @@ static int serialupdi_paged_load(const PROGRAMMER *pgm, const AVRPART *p, const unsigned int page_size, unsigned int addr, unsigned int n_bytes) { - if (n_bytes > m->readsize) { + if(n_bytes > 65535) { + pmsg_error("%s() called with implausibly high n_bytes = %u\n", __func__, n_bytes); + return -1; + } + + if ((int) n_bytes > m->readsize) { unsigned int read_offset = addr; - unsigned int remaining_bytes = n_bytes; + int remaining_bytes = n_bytes; int read_bytes = 0; int rc; + while (remaining_bytes > 0) { rc = updi_read_data(pgm, m->offset + read_offset, m->buf + read_offset, remaining_bytes > m->readsize ? m->readsize : remaining_bytes); @@ -733,10 +739,16 @@ static int serialupdi_paged_write(const PROGRAMMER *pgm, const AVRPART *p, const unsigned int addr, unsigned int n_bytes) { int rc; - if (n_bytes > m->page_size) { + + if(n_bytes > 65535) { + pmsg_error("%s() called with implausibly high n_bytes = %u\n", __func__, n_bytes); + return -1; + } + if ((int) n_bytes > m->page_size) { unsigned int write_offset = addr; - unsigned int remaining_bytes = n_bytes; + int remaining_bytes = n_bytes; int write_bytes = 0; + while (remaining_bytes > 0) { if (strcmp(m->desc, "eeprom")==0) { From 3521c9d9fb6d7c29e7bb2d3df0a3b199f9a38dc9 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 19:01:00 +0000 Subject: [PATCH 06/22] Silence sign-compare warnings in ser_avrdoper.c --- src/ser_avrdoper.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/ser_avrdoper.c b/src/ser_avrdoper.c index df82deee..ca46ca58 100644 --- a/src/ser_avrdoper.c +++ b/src/ser_avrdoper.c @@ -55,7 +55,7 @@ #define USB_VENDOR_ID 0x16c0 #define USB_PRODUCT_ID 0x05df -static int reportDataSizes[4] = {13, 29, 61, 125}; +static const int reportDataSizes[4] = {13, 29, 61, 125}; static unsigned char avrdoperRxBuffer[280]; /* buffer for receive data */ static int avrdoperRxLength = 0; /* amount of valid bytes in rx buffer */ @@ -232,7 +232,7 @@ static void avrdoper_close(union filedescriptor *fdp) static int chooseDataSize(int len) { - int i; + size_t i; for(i = 0; i < sizeof(reportDataSizes)/sizeof(reportDataSizes[0]); i++){ if(reportDataSizes[i] >= len) @@ -243,13 +243,17 @@ static int chooseDataSize(int len) static int avrdoper_send(const union filedescriptor *fdp, const unsigned char *buf, size_t buflen) { + if(buflen > INT_MAX) { + pmsg_error("%s() called with too large buflen = %lu\n", __func__, (unsigned long) buflen); + return -1; + } if(verbose > 3) dumpBlock("Send", buf, buflen); while(buflen > 0){ unsigned char buffer[256]; int rval, lenIndex = chooseDataSize(buflen); - int thisLen = buflen > reportDataSizes[lenIndex] ? - reportDataSizes[lenIndex] : buflen; + int thisLen = (int) buflen > reportDataSizes[lenIndex]? + reportDataSizes[lenIndex]: (int) buflen; buffer[0] = lenIndex + 1; /* report ID */ buffer[1] = thisLen; memcpy(buffer + 2, buf, thisLen); @@ -290,7 +294,7 @@ static int avrdoperFillBuffer(const union filedescriptor *fdp) { bytesPending = buffer[1] - len; /* amount still buffered */ if(len > buffer[1]) /* cut away padding */ len = buffer[1]; - if(avrdoperRxLength + len > sizeof(avrdoperRxBuffer)){ + if(avrdoperRxLength + len > (int) sizeof(avrdoperRxBuffer)){ pmsg_error("buffer overflow\n"); return -1; } From e089d7ecc5a157a018c3d09be14d6ce0a4626ba2 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 19:07:02 +0000 Subject: [PATCH 07/22] Silence sign-compare warnings in pindefs.c --- src/pindefs.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/pindefs.c b/src/pindefs.c index f28c5fde..9c31f0df 100644 --- a/src/pindefs.c +++ b/src/pindefs.c @@ -84,9 +84,7 @@ static int pin_fill_old_pinno(const struct pindef_t * const pindef, unsigned int * @param[out] pinno old pin definition integer */ static int pin_fill_old_pinlist(const struct pindef_t * const pindef, unsigned int * const pinno) { - int i; - - for(i = 0; i < PIN_FIELD_SIZE; i++) { + for(size_t i = 0; i < PIN_FIELD_SIZE; i++) { if(i == 0) { if((pindef->mask[i] & ~PIN_MASK) != 0) { pmsg_error("pins of higher index than max field size for old pinno found\n"); @@ -229,7 +227,6 @@ int pins_check(const PROGRAMMER *const pgm, const struct pin_checklist_t *const bool invalid = false; bool inverse = false; int index; - int segment; bool mandatory_used = false; pinmask_t invalid_used[PIN_FIELD_SIZE] = {0}; pinmask_t inverse_used[PIN_FIELD_SIZE] = {0}; @@ -246,7 +243,7 @@ int pins_check(const PROGRAMMER *const pgm, const struct pin_checklist_t *const } } - for(segment = 0; segment < PIN_FIELD_SIZE; segment++) { + for(size_t segment = 0; segment < PIN_FIELD_SIZE; segment++) { // check if for mandatory any pin is defined invalid_used[segment] = pgm->pin[pinname].mask[segment] & ~valid_pins->mask[segment]; if(is_mandatory && (0 != (pgm->pin[pinname].mask[segment] & valid_pins->mask[segment]))) { From aa258ace360c7840129641a221018ba6e106208a Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 19:32:16 +0000 Subject: [PATCH 08/22] Silence sign-compare warnings in pgm_type.c and clean up --- src/pgm_type.c | 58 +++++++++++--------------------------------------- 1 file changed, 13 insertions(+), 45 deletions(-) diff --git a/src/pgm_type.c b/src/pgm_type.c index 91400fea..70d3ec81 100644 --- a/src/pgm_type.c +++ b/src/pgm_type.c @@ -111,29 +111,17 @@ const PROGRAMMER_TYPE programmers_types[] = { // Name(s) the programmers call th {"xbee", xbee_initpgm, xbee_desc}, // "XBee" }; -const PROGRAMMER_TYPE * locate_programmer_type(const char * id) -{ - const PROGRAMMER_TYPE * p = NULL; - int i; - int found; - - found = 0; - - for (i = 0; i < sizeof(programmers_types)/sizeof(programmers_types[0]) && !found; i++) { - p = &(programmers_types[i]); - if (strcasecmp(id, p->id) == 0) - found = 1; - } - - if (found) - return p; +const PROGRAMMER_TYPE *locate_programmer_type(const char *id) { + for(size_t i = 0; i < sizeof programmers_types/sizeof*programmers_types; i++) + if(strcasecmp(id, programmers_types[i].id) == 0) + return programmers_types + i; return NULL; } // Return type id given the init function or "" if not found const char *locate_programmer_type_id(void (*initpgm)(PROGRAMMER *pgm)) { - for (int i=0; i < sizeof programmers_types/sizeof*programmers_types; i++) + for(size_t i=0; i < sizeof programmers_types/sizeof*programmers_types; i++) if(programmers_types[i].initpgm == initpgm) return programmers_types[i].id; @@ -142,35 +130,15 @@ const char *locate_programmer_type_id(void (*initpgm)(PROGRAMMER *pgm)) { /* - * Iterate over the list of programmers given as "programmers", and - * call the callback function cb for each entry found. cb is being + * Iterate over the list of programmer types given in the table above and + * call the callback function cb for each entry found. cb is being * passed the following arguments: - * . the name of the programmer (for -c) - * . the descriptive text given in the config file - * . the name of the config file this programmer has been defined in - * . the line number of the config file this programmer has been defined at - * . the "cookie" passed into walk_programmers() (opaque client data) + * - Name of the programmer + * - Descriptive text + * - "Cookie" passed into walk_programmer_types() for opaque client data */ - /* -void walk_programmer_types(LISTID programmer_types, walk_programmer_types_cb cb, void *cookie) -{ - LNODEID ln1; - PROGRAMMER * p; - for (ln1 = lfirst(programmers); ln1; ln1 = lnext(ln1)) { - p = ldata(ln1); - cb(p->id, p->desc, cookie); - } - } -}*/ - -void walk_programmer_types(walk_programmer_types_cb cb, void *cookie) -{ - const PROGRAMMER_TYPE * p; - int i; - - for (i = 0; i < sizeof(programmers_types)/sizeof(programmers_types[0]); i++) { - p = &(programmers_types[i]); - cb(p->id, p->desc, cookie); - } +void walk_programmer_types(walk_programmer_types_cb cb, void *cookie) { + for (size_t i = 0; i < sizeof(programmers_types)/sizeof(programmers_types[0]); i++) + cb(programmers_types[i].id, programmers_types[i].desc, cookie); } From 7f0fe41b6c2930305ea62226576ee172e631427e Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 22:56:41 +0000 Subject: [PATCH 09/22] Silence sign-compare warnings in micronucleus.c --- src/micronucleus.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/micronucleus.c b/src/micronucleus.c index 6f205e6a..9cd2c4c0 100644 --- a/src/micronucleus.c +++ b/src/micronucleus.c @@ -191,7 +191,7 @@ static int micronucleus_get_bootloader_info_v1(pdata_t* pdata) pmsg_warning("unable to get bootloader info block: %s\n", usb_strerror()); return result; } - else if (result < sizeof(buffer)) + else if ((size_t) result < sizeof(buffer)) { pmsg_warning("received invalid bootloader info block size: %d\n", result); return -1; @@ -258,7 +258,7 @@ static int micronucleus_get_bootloader_info_v2(pdata_t* pdata) pmsg_warning("unable to get bootloader info block: %s\n", usb_strerror()); return result; } - else if (result < sizeof(buffer)) + else if ((size_t) result < sizeof(buffer)) { pmsg_warning("received invalid bootloader info block size: %d\n", result); return -1; @@ -449,7 +449,7 @@ static int micronucleus_write_page_v2(pdata_t* pdata, uint32_t address, uint8_t* return result; } - for (int i = 0; i < size; i += 4) + for (uint32_t i = 0; i < size; i += 4) { int w1 = (buffer[i + 1] << 8) | (buffer[i + 0] << 0); int w2 = (buffer[i + 3] << 8) | (buffer[i + 2] << 0); @@ -491,7 +491,7 @@ static int micronucleus_write_page(pdata_t* pdata, uint32_t address, uint8_t* bu // Require software start. pdata->start_program = true; } - else if (address >= pdata->bootloader_start - pdata->page_size) + else if (address >= (uint32_t) (pdata->bootloader_start - pdata->page_size)) { if (pdata->major_version >= 2) { From cec9715ba23b405c72adad777adb202923991d79 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:09:56 +0000 Subject: [PATCH 10/22] Silence sign-compare warnings in lists.c --- src/lists.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lists.c b/src/lists.c index cab88364..c475736a 100644 --- a/src/lists.c +++ b/src/lists.c @@ -795,7 +795,7 @@ lget ( LISTID lid ) void * lget_n ( LISTID lid, unsigned int n ) { - int i; + unsigned int i; LIST * l; LISTNODE * ln; @@ -803,7 +803,7 @@ lget_n ( LISTID lid, unsigned int n ) CKLMAGIC(l); - if ((n<1)||(n>lsize(l))) { + if (n < 1 || n > (unsigned int) lsize(l)) { return NULL; } @@ -836,7 +836,7 @@ lget_n ( LISTID lid, unsigned int n ) LNODEID lget_ln ( LISTID lid, unsigned int n ) { - int i; + unsigned int i; LIST * l; LISTNODE * ln; @@ -844,7 +844,7 @@ lget_ln ( LISTID lid, unsigned int n ) CKLMAGIC(l); - if ((n<1)||(n>lsize(l))) { + if (n < 1 || n > (unsigned int) lsize(l)) { return NULL; } @@ -944,7 +944,7 @@ insert_ln ( LIST * l, LISTNODE * ln, void * data_ptr ) int lins_n ( LISTID lid, void * data_ptr, unsigned int n ) { - int i; + unsigned int i; LIST * l; LISTNODE * ln; @@ -952,7 +952,7 @@ lins_n ( LISTID lid, void * data_ptr, unsigned int n ) CKLMAGIC(l); - if ((n<1)||(n>(l->num+1))) { + if (n < 1 || n > (unsigned int) (l->num+1)) { return -1; } @@ -1185,7 +1185,7 @@ lrmv_ln ( LISTID lid, LNODEID lnid ) void * lrmv_n ( LISTID lid, unsigned int n ) { - int i; + unsigned int i; LIST * l; LISTNODE * ln; @@ -1193,7 +1193,7 @@ lrmv_n ( LISTID lid, unsigned int n ) CKLMAGIC(l); - if ((n<1)||(n>l->num)) { + if (n < 1 || n > (unsigned int) l->num) { return NULL; } From 6d15d24a4d8598336614d5769ca8ccd301b8e552 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:12:44 +0000 Subject: [PATCH 11/22] Fix fall through error in jtagmkI.c --- src/jtagmkI.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/jtagmkI.c b/src/jtagmkI.c index 9c3be6dd..d35c0925 100644 --- a/src/jtagmkI.c +++ b/src/jtagmkI.c @@ -182,6 +182,7 @@ static void jtagmkI_prmsg(const PROGRAMMER *pgm, unsigned char *data, size_t len case RESP_POWER: msg_info("target power lost\n"); + break; default: msg_info("unknown message 0x%02x\n", data[0]); From 507031badfc4152cf89ba25283dbab7ca743eaf4 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:18:08 +0000 Subject: [PATCH 12/22] Silence compiler warnings in jtagm.c --- src/jtagmkI.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/jtagmkI.c b/src/jtagmkI.c index d35c0925..d19f223c 100644 --- a/src/jtagmkI.c +++ b/src/jtagmkI.c @@ -83,7 +83,7 @@ struct pdata * to try connecting at startup, we keep these two entries on top to * speedup the program start. */ -const static struct { +static const struct { long baud; unsigned char val; } baudtab[] = { @@ -139,11 +139,10 @@ u16_to_b2(unsigned char *b, unsigned short l) } static void jtagmkI_prmsg(const PROGRAMMER *pgm, unsigned char *data, size_t len) { - int i; - if (verbose >= 4) { msg_trace("Raw message:\n"); + size_t i; for (i = 0; i < len; i++) { msg_trace("0x%02x ", data[i]); if (i % 16 == 15) @@ -472,9 +471,7 @@ static int jtagmkI_program_disable(const PROGRAMMER *pgm) { static unsigned char jtagmkI_get_baud(long baud) { - int i; - - for (i = 0; i < sizeof baudtab / sizeof baudtab[0]; i++) + for (size_t i = 0; i < sizeof baudtab / sizeof baudtab[0]; i++) if (baud == baudtab[i].baud) return baudtab[i].val; From 3b7f0d2c5545a89148ce144541423eefd61dd8fd Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:25:13 +0000 Subject: [PATCH 13/22] Use portable %lu and cast for size_t --- src/ft245r.c | 2 +- src/jtag3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ft245r.c b/src/ft245r.c index 8eab7d6f..5068903a 100644 --- a/src/ft245r.c +++ b/src/ft245r.c @@ -276,7 +276,7 @@ static int ft245r_recv(const PROGRAMMER *pgm, unsigned char *buf, size_t len) { ft245r_fill(pgm); #if FT245R_DEBUG - msg_info("%s: discarding %d, consuming %zu bytes\n", __func__, rx.discard, len); + msg_info("%s: discarding %d, consuming %lu bytes\n", __func__, rx.discard, (unsigned long) len); #endif while (rx.discard > 0) { int result = ft245r_rx_buf_fill_and_get(pgm); diff --git a/src/jtag3.c b/src/jtag3.c index 62b95779..470fae75 100644 --- a/src/jtag3.c +++ b/src/jtag3.c @@ -2586,7 +2586,7 @@ static int jtag3_send_tpi(const PROGRAMMER *pgm, unsigned char *data, size_t len cmdbuf[0] = SCOPE_AVR_TPI; if (len > INT_MAX) { - pmsg_error("invalid jtag3_send_tpi() packet length %zu\n", len); + pmsg_error("invalid jtag3_send_tpi() packet length %lu\n", (unsigned long) len); free(cmdbuf); return -1; } From 3c51fb6aae3182c87f23ec915e005a8cb97520a0 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:34:14 +0000 Subject: [PATCH 14/22] Silence sign-compare warnings in ft245r.c --- src/ft245r.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/ft245r.c b/src/ft245r.c index 5068903a..0167d8b5 100644 --- a/src/ft245r.c +++ b/src/ft245r.c @@ -166,14 +166,14 @@ static void ft245r_rx_buf_purge(const PROGRAMMER *pgm) { static void ft245r_rx_buf_put(const PROGRAMMER *pgm, uint8_t byte) { rx.len++; rx.buf[rx.wr++] = byte; - if (rx.wr >= sizeof(rx.buf)) + if (rx.wr >= (int) sizeof(rx.buf)) rx.wr = 0; } static uint8_t ft245r_rx_buf_get(const PROGRAMMER *pgm) { rx.len--; uint8_t byte = rx.buf[rx.rd++]; - if (rx.rd >= sizeof(rx.buf)) + if (rx.rd >= (int) sizeof(rx.buf)) rx.rd = 0; return byte; } @@ -246,10 +246,8 @@ static int ft245r_flush(const PROGRAMMER *pgm) { static int ft245r_send2(const PROGRAMMER *pgm, unsigned char *buf, size_t len, bool discard_rx_data) { - int i, j; - - for (i = 0; i < len; ++i) { - for (j = 0; j < baud_multiplier; ++j) { + for (size_t i = 0; i < len; ++i) { + for (int j = 0; j < baud_multiplier; ++j) { if (discard_rx_data) ++rx.discard; tx.buf[tx.len++] = buf[i]; @@ -270,8 +268,6 @@ static int ft245r_send_and_discard(const PROGRAMMER *pgm, unsigned char *buf, } static int ft245r_recv(const PROGRAMMER *pgm, unsigned char *buf, size_t len) { - int i, j; - ft245r_flush(pgm); ft245r_fill(pgm); @@ -288,7 +284,7 @@ static int ft245r_recv(const PROGRAMMER *pgm, unsigned char *buf, size_t len) { --rx.discard; } - for (i = 0; i < len; ++i) + for (size_t i = 0; i < len; ++i) { int result = ft245r_rx_buf_fill_and_get(pgm); if (result < 0) @@ -297,7 +293,7 @@ static int ft245r_recv(const PROGRAMMER *pgm, unsigned char *buf, size_t len) { } buf[i] = (uint8_t)result; - for (j = 1; j < baud_multiplier; ++j) + for (int j = 1; j < baud_multiplier; ++j) { result = ft245r_rx_buf_fill_and_get(pgm); if (result < 0) @@ -1054,7 +1050,7 @@ static int ft245r_paged_write_flash(const PROGRAMMER *pgm, const AVRPART *p, con avr_set_bits(m->op[spi], cmd); avr_set_addr(m->op[spi], cmd, addr/2); avr_set_input(m->op[spi], cmd, m->buf[addr]); - for(int k=0; k= (int) n_bytes || j >= FT245R_FRAGMENT_SIZE/FT245R_CMD_SIZE) { - if(i >= n_bytes) { + if(i >= (int) n_bytes) { ft245r_out = SET_BITS_0(ft245r_out, pgm, PIN_AVR_SCK, 0); // SCK down buf[buf_pos++] = ft245r_out; } else { @@ -1150,7 +1146,7 @@ static int ft245r_paged_load_flash(const PROGRAMMER *pgm, const AVRPART *p, cons avr_set_addr(m->op[AVR_OP_LOAD_EXT_ADDR], cmd, addr/2); buf_pos = 0; - for(int k=0; kop[spi], cmd); avr_set_addr(m->op[spi], cmd, addr/2); - for(int k=0; k Date: Wed, 11 Jan 2023 23:38:43 +0000 Subject: [PATCH 15/22] Silence sign-compare warnings in flip2.c --- src/flip2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/flip2.c b/src/flip2.c index 84609576..f85905ca 100644 --- a/src/flip2.c +++ b/src/flip2.c @@ -459,7 +459,7 @@ int flip2_paged_load(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM *m result = flip2_read_memory(FLIP2(pgm)->dfu, mem_unit, addr, mem->buf + addr, n_bytes); - return (result == 0) ? n_bytes : -1; + return result == 0? (int) n_bytes: -1; } int flip2_paged_write(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM *mem, @@ -490,7 +490,7 @@ int flip2_paged_write(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM * result = flip2_write_memory(FLIP2(pgm)->dfu, mem_unit, addr, mem->buf + addr, n_bytes); - return (result == 0) ? n_bytes : -1; + return result == 0? (int) n_bytes: -1; } // Parse the -E option flag @@ -520,7 +520,7 @@ int flip2_read_sig_bytes(const PROGRAMMER *pgm, const AVRPART *part, const AVRME if (FLIP2(pgm)->dfu == NULL) return -1; - if (mem->size < sizeof(FLIP2(pgm)->part_sig)) { + if (mem->size < (int) sizeof(FLIP2(pgm)->part_sig)) { pmsg_error("signature read must be at least %u bytes\n", (unsigned int) sizeof(FLIP2(pgm)->part_sig)); return -1; } From 81f01939c284e201fafcc97658f4f0ecd9f951fd Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:45:07 +0000 Subject: [PATCH 16/22] Silence missing-field-initializers warning in flip1.c --- src/flip1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flip1.c b/src/flip1.c index 19960f31..2a85ccaa 100644 --- a/src/flip1.c +++ b/src/flip1.c @@ -652,7 +652,7 @@ int flip1_write_memory(struct dfu_dev *dfu, int cmd_result = 0; int aux_result; struct flip1_cmd_header cmd_header = { - FLIP1_CMD_PROG_START, mem_unit + FLIP1_CMD_PROG_START, mem_unit, {0}, {0}, {0}, }; struct flip1_prog_footer cmd_footer = { { 0, 0, 0, 0 }, /* CRC */ From b75e26bf6d9520a6285e06ab26df6722c70a0682 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:48:04 +0000 Subject: [PATCH 17/22] Silence sign-compare warnings in flip1.c --- src/flip1.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/flip1.c b/src/flip1.c index 2a85ccaa..99193461 100644 --- a/src/flip1.c +++ b/src/flip1.c @@ -374,7 +374,7 @@ int flip1_read_byte(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM *me if (strcmp(mem->desc, "signature") == 0) { if (flip1_read_sig_bytes(pgm, part, mem) < 0) return -1; - if (addr >= mem->size) { + if (addr >= (unsigned long) mem->size) { pmsg_error("signature address %lu out of range [0, %d]\n", addr, mem->size-1); return -1; } @@ -461,7 +461,7 @@ int flip1_paged_write(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM * result = flip1_write_memory(FLIP1(pgm)->dfu, mem_unit, addr, mem->buf + addr, n_bytes); - return (result == 0) ? n_bytes : -1; + return result == 0? (int) n_bytes: -1; } int flip1_read_sig_bytes(const PROGRAMMER *pgm, const AVRPART *part, const AVRMEM *mem) { @@ -470,7 +470,7 @@ int flip1_read_sig_bytes(const PROGRAMMER *pgm, const AVRPART *part, const AVRME if (FLIP1(pgm)->dfu == NULL) return -1; - if (mem->size < sizeof(FLIP1(pgm)->part_sig)) { + if (mem->size < (int) sizeof(FLIP1(pgm)->part_sig)) { pmsg_error("signature read must be at least %u bytes\n", (unsigned int) sizeof(FLIP1(pgm)->part_sig)); return -1; } From 7ad5289d6661f9b31e820108f18f28b50586912c Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:50:26 +0000 Subject: [PATCH 18/22] Silence sign-compare warnings in dfu.c --- src/dfu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dfu.c b/src/dfu.c index a51c93db..f5343158 100644 --- a/src/dfu.c +++ b/src/dfu.c @@ -275,12 +275,12 @@ int dfu_getstatus(struct dfu_dev *dfu, struct dfu_status *status) return -1; } - if (result < sizeof(struct dfu_status)) { + if (result < (int) sizeof(struct dfu_status)) { pmsg_error("unable to get DFU status: %s\n", "short read"); return -1; } - if (result > sizeof(struct dfu_status)) { + if (result > (int) sizeof(struct dfu_status)) { pmsg_error("oversize read (should not happen); exiting\n"); exit(1); } From e349cd1f6b46f65d9e462d5fe1b40266fa1ad2a0 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:52:59 +0000 Subject: [PATCH 19/22] Silence sign-compare warning in buterfly.c --- src/butterfly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/butterfly.c b/src/butterfly.c index 98894ea7..a71d55e6 100644 --- a/src/butterfly.c +++ b/src/butterfly.c @@ -662,7 +662,7 @@ static int butterfly_paged_load(const PROGRAMMER *pgm, const AVRPART *p, const A butterfly_set_addr(pgm, addr / rd_size); } while (addr < max_addr) { - if ((max_addr - addr) < blocksize) { + if ((max_addr - addr) < (unsigned int) blocksize) { blocksize = max_addr - addr; }; cmd[1] = (blocksize >> 8) & 0xff; From 6088c9b98f1555f17a87994383580ac0ae20382f Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Wed, 11 Jan 2023 23:55:07 +0000 Subject: [PATCH 20/22] Silence sign-compare warning in avr910.c --- src/avr910.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/avr910.c b/src/avr910.c index d8d29332..d80915d9 100644 --- a/src/avr910.c +++ b/src/avr910.c @@ -653,9 +653,9 @@ static int avr910_paged_load(const PROGRAMMER *pgm, const AVRPART *p, const AVRM avr910_set_addr(pgm, addr / rd_size); while (addr < max_addr) { - if ((max_addr - addr) < blocksize) { + if (max_addr - addr < (unsigned int) blocksize) blocksize = max_addr - addr; - } + cmd[1] = (blocksize >> 8) & 0xff; cmd[2] = blocksize & 0xff; From 22f9bc5260160248ef0738d73f5b8857e3bc6d74 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Thu, 12 Jan 2023 00:01:46 +0000 Subject: [PATCH 21/22] Enable -Wextra -Wno-unused-parameter by default for gcc --- src/CMakeLists.txt | 2 +- src/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index c51214e6..bb281b70 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -77,7 +77,7 @@ if(MSVC) ) else() set(LIB_MATH m) - add_compile_options(-Wall) # -Wextra + add_compile_options(-Wall -Wextra -Wno-unused-parameter) endif() # ===================================== diff --git a/src/configure.ac b/src/configure.ac index b57af4a6..de507461 100644 --- a/src/configure.ac +++ b/src/configure.ac @@ -429,7 +429,7 @@ fi # If we are compiling with gcc, enable all warnings and make warnings errors. if test "$GCC" = yes; then - ENABLE_WARNINGS="-Wall" + ENABLE_WARNINGS="-Wall -Wextra -Wno-unused-parameter" # does this compiler support -Wno-pointer-sign ? AC_MSG_CHECKING([if gcc accepts -Wno-pointer-sign ]) From f9c5c0cfbce40c096a73a465e3ad2b1c4e230d60 Mon Sep 17 00:00:00 2001 From: Stefan Rueger Date: Thu, 12 Jan 2023 14:09:38 +0000 Subject: [PATCH 22/22] Silence sign-cpmpare warnings in pickit2.c --- src/pickit2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pickit2.c b/src/pickit2.c index ca8824f9..7014b069 100644 --- a/src/pickit2.c +++ b/src/pickit2.c @@ -199,7 +199,7 @@ static int pickit2_open(PROGRAMMER *pgm, const char *port) { strcpy(cbuf, pgm->desc); // Convert from wide chars and overlay over initial part of desc - for (int i = 0; i < sizeof wbuf/sizeof*wbuf && wbuf[i]; i++) + for(size_t i = 0; i < sizeof wbuf/sizeof*wbuf && wbuf[i]; i++) cbuf[i] = (char) wbuf[i]; // TODO what about little/big endian??? pgm->desc = cache_string(cbuf); } @@ -1058,7 +1058,7 @@ static int usb_read_interrupt(const PROGRAMMER *pgm, void *buff, int size, int t GetOverlappedResult(PDATA(pgm)->usb_handle, &ovr, &bytesRead, 0); - return bytesRead > 0 ? bytesRead : -1; + return bytesRead > 0? (int) bytesRead: -1; } // simple write with timeout @@ -1083,7 +1083,7 @@ static int usb_write_interrupt(const PROGRAMMER *pgm, const void *buff, int size GetOverlappedResult(PDATA(pgm)->usb_handle, &ovr, &bytesWritten, 0); - return bytesWritten > 0 ? bytesWritten : -1; + return bytesWritten > 0? (int) bytesWritten: -1; } static int pickit2_write_report(const PROGRAMMER *pgm, const unsigned char report[65]) {