From 1e05c4339fc939f1a99e71275246903e42391952 Mon Sep 17 00:00:00 2001 From: Joerg Wunsch Date: Mon, 15 Feb 2016 20:22:26 +0000 Subject: [PATCH] patch #8896: Silence cppcheck warnings in 6.2 code git-svn-id: svn://svn.savannah.nongnu.org/avrdude/trunk/avrdude@1372 81a1dc3b-b13d-400b-aceb-764788c761c2 --- ChangeLog | 5 +++++ NEWS | 1 + linuxgpio.c | 8 ++++---- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7693a31d..1132613c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-02-15 Joerg Wunsch + + patch #8896: Silence cppcheck warnings in 6.2 code + * linuxgpio.c: Use %ud to print GPIO values. + 2016-02-15 Joerg Wunsch patch #8735: ATtiny28 support in avrdude.conf diff --git a/NEWS b/NEWS index 3a57437e..076257aa 100644 --- a/NEWS +++ b/NEWS @@ -27,6 +27,7 @@ Current: - patch #8435: Implementing mEDBG CMSIS-DAP protocol - patch #8735: ATtiny28 support in avrdude.conf + - patch #8896: Silence cppcheck warnings in 6.2 code * Internals: diff --git a/linuxgpio.c b/linuxgpio.c index 00fc236e..b6181735 100644 --- a/linuxgpio.c +++ b/linuxgpio.c @@ -66,7 +66,7 @@ static int linuxgpio_export(unsigned int gpio) return fd; } - len = snprintf(buf, sizeof(buf), "%d", gpio); + len = snprintf(buf, sizeof(buf), "%ud", gpio); r = write(fd, buf, len); close(fd); @@ -84,7 +84,7 @@ static int linuxgpio_unexport(unsigned int gpio) return fd; } - len = snprintf(buf, sizeof(buf), "%d", gpio); + len = snprintf(buf, sizeof(buf), "%ud", gpio); r = write(fd, buf, len); close(fd); @@ -95,7 +95,7 @@ static int linuxgpio_openfd(unsigned int gpio) { char filepath[60]; - snprintf(filepath, sizeof(filepath), "/sys/class/gpio/gpio%d/value", gpio); + snprintf(filepath, sizeof(filepath), "/sys/class/gpio/gpio%ud/value", gpio); return (open(filepath, O_RDWR)); } @@ -104,7 +104,7 @@ static int linuxgpio_dir(unsigned int gpio, unsigned int dir) int fd, r; char buf[60]; - snprintf(buf, sizeof(buf), "/sys/class/gpio/gpio%d/direction", gpio); + snprintf(buf, sizeof(buf), "/sys/class/gpio/gpio%ud/direction", gpio); fd = open(buf, O_WRONLY); if (fd < 0) {